On Thu, 2014-06-05 at 09:54 +0530, Arun Kumar K wrote: > Hi Ben, > > On Wed, Jun 4, 2014 at 5:43 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > > On Wed, 2014-06-04 at 13:08 +0200, Kamil Debski wrote: > >> Hi Arun, Ben, > >> > >> > >> > From: arunkk.samsung@xxxxxxxxx [mailto:arunkk.samsung@xxxxxxxxx] On > >> > Behalf Of Arun Kumar K > >> > Sent: Wednesday, June 04, 2014 7:32 AM > >> > > >> > Hi Ben, > >> > > >> > On Wed, Jun 4, 2014 at 4:56 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> [...] > >> > > Just noticed a problem with all the s5p-mfc firmware: you are putting > >> > > it in the s5p-mfc subdirectory, so distribution packages will install > >> > > them in /lib/firmware/s5p-mfc. However, unless I'm mistaken your > >> > > driver requests it with a bare filename (e.g. "s5p-mfc-v7.fw") so it > >> > > won't be found. > >> > > > >> > > >> > Yes this issue is there. > >> > Kamil, are you ok with changing the fw load path to s5p-mfc/s5p-mfc*.fw > >> > in the driver? > >> > >> We have two options here: > >> 1) Change the driver to request s5p-mfc/sp5-mfc-fw* > >> 2) Move the files in the firmware repository > >> > >> I would opt for the second option. The driver was uploaded before the > >> firmware. I see that there are many firmware files in the root folder > >> of the repository > >> > >> Ben, what is your opinion? Which is preferred: creating subdirectories > >> or storing firmware in the root folder? > > > > I prefer subdirectories, but compatibility wins. So I'll apply the > > following patch if no-one objects. > > > > Ben. > > > > --- > > Subject: Move the s5p-mfc firmware out of its subdirectory > > > > The driver does not include this subdirectory name when requesting > > firmware. > > > > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx> > > --- > > WHENCE | 10 +++++----- > > s5p-mfc/s5p-mfc-v6-v2.fw => s5p-mfc-v6-v2.fw | Bin > > s5p-mfc/s5p-mfc-v6.fw => s5p-mfc-v6.fw | Bin > > s5p-mfc/s5p-mfc-v7.fw => s5p-mfc-v7.fw | Bin > > s5p-mfc/s5p-mfc-v8.fw => s5p-mfc-v8.fw | Bin > > s5p-mfc/s5p-mfc.fw => s5p-mfc.fw | Bin > > 6 files changed, 5 insertions(+), 5 deletions(-) > > rename s5p-mfc/s5p-mfc-v6-v2.fw => s5p-mfc-v6-v2.fw (100%) > > rename s5p-mfc/s5p-mfc-v6.fw => s5p-mfc-v6.fw (100%) > > rename s5p-mfc/s5p-mfc-v7.fw => s5p-mfc-v7.fw (100%) > > rename s5p-mfc/s5p-mfc-v8.fw => s5p-mfc-v8.fw (100%) > > rename s5p-mfc/s5p-mfc.fw => s5p-mfc.fw (100%) [...] > Looks good to me. I've made this change. Ben. -- Ben Hutchings When in doubt, use brute force. - Ken Thompson
Attachment:
signature.asc
Description: This is a digitally signed message part
