On Tue, 2014-06-03 at 20:34 +0100, Ben Hutchings wrote: > On Wed, 2014-05-21 at 18:11 +0530, Arun Kumar K wrote: > > Adding the following firmware files for MFC > > s5p-mfc-v7.fw: Used in exynos 5420 > > s5p-mfc-v8.fw: Used in exynos 5800 > > > > Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx> > > --- > > Changes from v1 > > - None > > --- > > WHENCE | 2 ++ > > s5p-mfc/s5p-mfc-v7.fw | Bin 0 -> 382724 bytes > > s5p-mfc/s5p-mfc-v8.fw | Bin 0 -> 360576 bytes > > 3 files changed, 2 insertions(+) > > create mode 100644 s5p-mfc/s5p-mfc-v7.fw > > create mode 100644 s5p-mfc/s5p-mfc-v8.fw > [...] > > Applied, thanks. Just noticed a problem with all the s5p-mfc firmware: you are putting it in the s5p-mfc subdirectory, so distribution packages will install them in /lib/firmware/s5p-mfc. However, unless I'm mistaken your driver requests it with a bare filename (e.g. "s5p-mfc-v7.fw") so it won't be found. Ben. -- Ben Hutchings Experience is what causes a person to make new mistakes instead of old ones.
Attachment:
signature.asc
Description: This is a digitally signed message part
