Chirantan Ekbote wrote:
>
> Hi Kukjin,
>
Hi,
> On Wed, May 21, 2014 at 5:47 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> > Yeah, actually we don't need to reset the count value after suspend/resume.
> > So, how about following? I think, it should be fine to you.
> >
> > diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
> > index 8d64200..d24db6f 100644
> > --- a/drivers/clocksource/exynos_mct.c
> > +++ b/drivers/clocksource/exynos_mct.c
> > @@ -157,12 +157,15 @@ static void exynos4_mct_frc_start(u32 hi, u32 lo)
> > {
> > u32 reg;
> >
> > - exynos4_mct_write(lo, EXYNOS4_MCT_G_CNT_L);
> > - exynos4_mct_write(hi, EXYNOS4_MCT_G_CNT_U);
> > -
> > reg = __raw_readl(reg_base + EXYNOS4_MCT_G_TCON);
> > - reg |= MCT_G_TCON_START;
> > - exynos4_mct_write(reg, EXYNOS4_MCT_G_TCON);
> > +
> > + if (!(reg & MCT_G_TCON_START)) {
> > + exynos4_mct_write(lo, EXYNOS4_MCT_G_CNT_L);
> > + exynos4_mct_write(hi, EXYNOS4_MCT_G_CNT_U);
> > +
> > + reg |= MCT_G_TCON_START;
> > + exynos4_mct_write(reg, EXYNOS4_MCT_G_TCON);
> > + }
> > }
> >
> >
>
> As Doug mentioned, this seems more complicated than necessary since
> the kernel doesn't care about the initial value of the mct counter at
> all. Is there some reason from a hardware standpoint that the counter
> needs to be cleared? If not, I would rather just delete the two
> offending lines. I am sending a patch that does this instead.
>
So decision point is that the initialization of MCT counter is required or not
when kernel begins. Yes it doesn't matter, basically MCT start has no problem
with any initial value and additionally its hardware reset value is 0x0.
OK, your suggestion is fair enough.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
