Byungho An <bh74.an@xxxxxxxxxxx> : > Florian Fainelli wrote: [...] > > I think that at some point you should revisit your abstraction, all > > the patches that I see do take a void __iomem * argument as the first > > function argument, you should probably use your driver private context > > here. The day you support a different version of the hardware, there > > might be other differences that need to be taken care of. > > > I agree with you, it would be more robust for different version of the hardware and make simple function argument. > But most functions of this driver deal with read/write register using ioaddr. It does not imply that they should urge on ioaddr. drivers/net/ethernet/broadcom/tg3.c gets it right and there is no reason why sxgbe should be different. > As of now I think it is enough but I'll consider it later. In the meantime: 1) more use-once function pointers are added 2) their parameter list keeps growing Please reconsider sooner than later. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |