Thanks to Amit Kachhap & Viresh Kumar > -----Original Message----- > From: Viresh Kumar [mailto:viresh.kumar@xxxxxxxxxx] > Sent: Tuesday, April 29, 2014 3:21 PM > To: Amit Kachhap > Cc: Jonghwan Choi; Kukjin Kim; linux-samsung-soc; Rafael J. Wysocki; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; open list:CPU FREQUENCY DRI... > Subject: Re: [PATCH 2/2] cpufreq: Remove exynos_sort_descend_freq_table in > exynos5440-cpufreq.c > > On 29 April 2014 11:44, Amit Kachhap <amit.kachhap@xxxxxxxxx> wrote: > > In the frequency table dts file, the frequencies are arranged in > > descending order which maps 1 to 1 with other frequency parameter to > > be calculated and programmed in some registers. > > But the OPP library works by generating the frequencies in ascending > > order which breaks the above logic. Ideally i should expect frequency > > values in same order as what is supplied. > > So OPP library should not change the order or should take input flags > > flags like, dev_pm_opp_init_cpufreq_table(TABLE_ORDER_ASCEND| > > TABLE_ORDER_DESCEND|TABLE_ORDER_ORIGINAL ) > > Looks a good idea :) > > This is what I wrote in another thread: > > What I would recommend is, use .driver_data field to hold what has to be > written to hardware for any frequency. And then simply use driver_data > instead of index. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |