<snip> > > >> Are these compatible strings documented anywhere? > > > > > > The "-clk" compatible strings are (in next patch). The "-rtc" and > > > "-regulators" are not. > > > > Hmm, this doesn't sound good. > > > > > Actually they aren't also used by child driver (each child driver parses > > > from parent of_node). > > > > Do you need to add compatible strings to mfd_cell entries of such cells > > then? > > From my point of view there isn't any special need for them (except for > clk). > > Dear Lee, > > Do you wish to have these compatibles for all of child drivers even when > they aren't used directly by them? If yes then probably I should > document them. It's your call, either remove the unused ones or document them all. I don't really mind either way. In the previous version I asked if there was any reason why you weren't applying compatible strings to the other cells; "subordinate drivers don't use them" is a perfectly reasonable reason. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |