On Wed, 2014-02-19 at 13:08 +0900, Mark Brown wrote: > On Tue, Feb 18, 2014 at 09:12:09AM +0100, Krzysztof Kozlowski wrote: > > On Tue, 2014-02-18 at 09:35 +0900, Mark Brown wrote: > > > > I don't understand the above? Are you saying that suspend mode actually > > > turns off the regulator or something else? If it's a separate setting > > > for suspend mode then it should be using the core suspend mode stuff. > > > No, it is similar to external control (by GPIO) except that regulator is > > controlled by PWREN pin. The PMIC's PWREN is not a GPIO, but instead it > > is directly connected to AP (for Exynos 4212: XPWRRGTON). In AP's normal > > mode the XPWRRGTON/PWREN is high. In sleep mode *AP* sets it low. > > How is that different to suspend mode then? Now I see... there is no difference. It seems that the whole idea of opmode can be replaced with suspend modes and regulator modes. I can't only find a way to set this from DTS. There are no bindings for regulation_constraints->state_{disk,mem,standby}. Should the driver set manually after obtaining init_data from DTS? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html