Guenter and Olof, On Mon, Dec 2, 2013 at 1:36 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote: >> On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: >> > On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote: >> >> A good watchdog driver is supposed to report when it was responsible >> >> for resetting the system. Implement this for the s3c2410, at least on >> >> exynos5250 and exynos5420 where we already have a pointer to the PMU >> >> registers to read the information. >> >> >> >> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx> >> >> --- >> >> This patch is based atop Leela Krishna's recent series that ends with >> >> (ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420) >> >> AKA <https://patchwork.kernel.org/patch/3251861/>. >> >> >> >> drivers/watchdog/s3c2410_wdt.c | 42 +++++++++++++++++++++++++++++++++++++++--- >> >> 1 file changed, 39 insertions(+), 3 deletions(-) >> >> >> >> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c >> >> index 47f4dcf..2c87d37 100644 >> >> --- a/drivers/watchdog/s3c2410_wdt.c >> >> +++ b/drivers/watchdog/s3c2410_wdt.c >> >> @@ -62,9 +62,13 @@ >> >> #define CONFIG_S3C2410_WATCHDOG_ATBOOT (0) >> >> #define CONFIG_S3C2410_WATCHDOG_DEFAULT_TIME (15) >> >> >> >> +#define RST_STAT_REG_OFFSET 0x0404 >> >> #define WDT_DISABLE_REG_OFFSET 0x0408 >> >> #define WDT_MASK_RESET_REG_OFFSET 0x040c >> >> #define QUIRK_NEEDS_PMU_CONFIG (1 << 0) >> >> +#define QUIRK_HAS_RST_STAT (1 << 1) >> >> +#define QUIRKS_NEED_PMUREG (QUIRK_NEEDS_PMU_CONFIG | \ >> >> + QUIRK_HAS_RST_STAT) >> >> >> > I am not really happy about the NEED (both of them, really) here. >> > How about HAS instead ? >> >> Ah, I just commented on these things on our internal review site too >> on this patch. I don't even think a quirk is needed -- just use the >> presence of a non-0 rst_stat_reg to tell if you need to use regmap. >> > Agreed; same is true for the QUIRK_NEEDS_PMU_CONFIG related registers > as well. I have changed all instances of NEED / NEEDS and HAS / HAVE. Please take a look. Since some of those changes applied to Leela Krishna's patch I'm sending up a "fixup" patch which hopefully he can incorporate into a v12. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |