Hi Mark, On Tue, Nov 12, 2013 at 7:18 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > From: Mark Brown <broonie@xxxxxxxxxx> > > In preparation for using the dmaengine helpers in ASoC rather than the > dmaengine wrappers for the Samsung API wrap the configuration of dma_data. > The dmaengine code expects different data to that used by the legacy API. > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> > --- > sound/soc/samsung/ac97.c | 51 +++++++++++++++--------------------------------- > sound/soc/samsung/dma.c | 8 ++++++++ > sound/soc/samsung/dma.h | 3 +++ > sound/soc/samsung/i2s.c | 2 +- > sound/soc/samsung/pcm.c | 18 +++++++++-------- > 5 files changed, 38 insertions(+), 44 deletions(-) > [snip] > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index a5cbdb4..67d9fa9 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -963,7 +963,7 @@ static int samsung_i2s_dai_probe(struct snd_soc_dai *dai) > } > clk_prepare_enable(i2s->clk); > > - snd_soc_dai_init_dma_data(dai, &i2s->dma_playback, &i2s->dma_capture); > + samsung_asoc_init_dma_data(dai, &i2s->dma_playback, &i2s->dma_capture); we have to initialize the dma data for i2s secondary dai also otherwise there is a crash in dmaengine_pcm_new during probe. Thanks Padma -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |