Hi Tomasz, On 17 October 2013 18:35, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: > Hi Sachin, > > On Thursday 17 of October 2013 17:33:12 Sachin Kamat wrote: >> L2x0 cache controller is present only in Cortex-A9 based Exynos4 SoCs. >> Thus move this function to Exynos4 early init call to avoid non-Exynos4 >> SoCs from calling this function in multi-platform support. > > I believe that at the time .init_early() is called there is no ioremap() > infrastructure working yet and so L2 cache initialization which needs > it will cause a kernel panic. This patch worked only because currently > there is no L2X0 controller defined in device tree sources of Exynos 4. It is not clear to me as to why device tree entry is required for this to work in current form as we call the L2X0 init function explicitly. > > Other than that, it will be required to register firmware operations > before L2X0 initialization, because on some boards it is needed to > initialize the L2 cache through secure firmware. > > Please let me handle this by the way of patches adding firmware based > L2X0 initialization. Sure, please go ahead. BTW, any rough estimate about when you plan to post them? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |