Hi Tomasz, [ ... ] > /* > * list of controller registers to be saved and restored during a > * suspend/resume cycle. > @@ -288,6 +299,70 @@ static unsigned long exynos4_clk_regs[] __initdata = { > GATE_IP_CPU, > }; > > +static int exynos4_clk_suspend(void) > +{ > + samsung_clk_save(reg_base, exynos4_save_common, > + ARRAY_SIZE(exynos4_clk_regs)); a doubt here, Is sizeof(exynos4_clk_regs) works with exynos4_clk_regs[] as __initdata ? > + > + if (exynos4_soc == EXYNOS4210) > + samsung_clk_save(reg_base, exynos4_save_soc, > + ARRAY_SIZE(exynos4210_clk_save)); [ ... ] > +static void exynos4_clk_sleep_init(void) I think, this fuction can be placed in __init section. Same in other patches as well. Regards, Yadwinder -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html