Re: [PATCH] cpufreq: exynos: Convert exynos-cpufreq to platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, October 17, 2013 2:00 PM, Sachin Kamat wrote:
> On 16 October 2013 21:30, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote:
> > From: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> >
> > +static struct platform_driver exynos_cpufreq_platdrv = {
> > +       .driver = {
> > +               .name   = "exynos-cpufreq",
> > +               .owner  = THIS_MODULE,
> > +       },
> > +       .probe = exynos_cpufreq_init,
> 
> I think the prototype of this function should be changed to:
> static int __init exynos_cpufreq_init(struct platform_device *pdev)
> 
> to avoid compilation warnings.

Hi Tomasz Figa,

One more thing. :-)

It makes section mismatch warning. Also, module_platform_driver()
is used. Then, '__init' annotation can be removed in order to fix
the section mismatch warning.

static int exynos_cpufreq_init(struct platform_device *pdev)

Thank you.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux