Hi Sachin,
On Thu, Oct 10, 2013 at 5:12 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> On 10 October 2013 16:11, Rajeshwari S Shinde <rajeshwari.s@xxxxxxxxxxx> wrote:
>> + if(sdd->cur_bpw == 32) {
>> + /* For word transfer we need to swap bytes */
>> + u32 swapcfg = (S3C64XX_SPI_SWAP_TX_EN | S3C64XX_SPI_SWAP_TX_BYTE |
>> + S3C64XX_SPI_SWAP_TX_HALF_WORD |
>> + S3C64XX_SPI_SWAP_RX_EN |
>> + S3C64XX_SPI_SWAP_RX_BYTE |
>> + S3C64XX_SPI_SWAP_RX_HALF_WORD);
>> + writel(swapcfg, regs + S3C64XX_SPI_SWAP_CFG);
>> + } else
>> + writel(0, regs + S3C64XX_SPI_SWAP_CFG);
>
> coding style: braces needed around else as 'if' block has it. I had
> pointed this out on v1 of this patch too.
Yes my mistake, missed correcting them, will correct in next version.
>
> [snip]
>
>> + /*
>> + * Enable byte tranfer if transfer length not a multiple of
>
> typo: s/tranfer/transfer
will correct this.
--
Regards,
Rajeshwari Shinde
>
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
