Re: [PATCH] ARM: SAMSUNG: Remove unused s5p_device_ehci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 10 of October 2013 14:29:58 Jingoo Han wrote:
> On Thursday, October 10, 2013 2:18 PM, Tomasz Figa wrote:
> > On Thursday 10 of October 2013 11:40:22 Jingoo Han wrote:
> > > On Thursday, October 10, 2013 11:26 AM, Sylwester Nawrocki wrote:
> [....]
> 
> > > > Are you planning to remove also this file altogether ? Probably the
> > > > s5p-ehci driver could be cleaned up then and the platform_data
> > > > handling
> > > > dropped from it as a follow up.
> > > 
> > > Hi Sylwester Nawrocki,
> > > 
> > > I will rename s5p-ehci to s5p-exynos, then drop platform_data handling
> > > from it. These will be separate patches.
> > > Thank you your comment. :-)
> > 
> > I'd recommend keeping driver name as is. S5PV210 is going to receive DT
> > support soon and it will be also able to use this driver.
> 
> Hi Tomasz Figa,
> 
> Now, Exynos EHCI and OHCI driver's name is different as below:
>  ehci-s5p.c
>  ohci-exynos.c

Hmm, right, this inconsistency is a good point.

> I want to use same name. There is no reason to keep the different names.
> Also I want to use '-exynos.c' even though S5PV210 can support EHCI and
> OHCI. ehci-exynos.c
>  ohci-exynos.c

OK. S5PV210 is basically Exynos 3, so I guess it's fine. Although I'd suggest 
having a note in Kconfig entries of these drivers that they can be also used on 
S5PV210.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux