On Monday 30 of September 2013 13:56:39 Sachin Kamat wrote: > On 30 September 2013 12:55, Kukjin Kim <kgene@xxxxxxxxxx> wrote: > > I think current patch looks good to me, and in this case I don't have > > any idea why we should macro for just one time usage. > > It is not the question of one time usage, it is just to make the code > more readable. I tend to agree with Sachin on this. Code as in current version of the patch reads as "write 0x1 to register offset by 0x14 from clock controller base", while it should read "write RESET_VAL to RESET_CTRL register of clock controller" (names made up) for people doing further work on this file to quickly find what the code does or allow referring to SoC documentation. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |