Jungseok Lee wrote: > > On Monday, September 30, 2013 12:04 PM, Sachin Kamat wrote: > > On 30 September 2013 07:02, Jungseok Lee <jays.lee@xxxxxxxxxxx> wrote: > > > > > + /* turn off all power domains */ > > > + addr = of_iomap(np, 0) + 0x14; > > > + __raw_writel(0x1, addr); > > > > Actually my comment was more about mentioning what these above values > > especially 0x14 represented? Either using a macro (preferred way) or > > atleast a comment. > > How about changing a variable name "addr" to "power_down_reg"? > > 0x14 is only available for exynos5440, not exynos5. Currently, there are > no > macros for specific SoCs in exynos5, such as exynos5250 or exynos5420. > That is > why I hesitate to add a macro for 0x14. > I think current patch looks good to me, and in this case I don't have any idea why we should macro for just one time usage. Applied, thanks. Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |