On 30 September 2013 07:02, Jungseok Lee <jays.lee@xxxxxxxxxxx> wrote: > + /* turn off all power domains */ > + addr = of_iomap(np, 0) + 0x14; > + __raw_writel(0x1, addr); Actually my comment was more about mentioning what these above values especially 0x14 represented? Either using a macro (preferred way) or atleast a comment. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html