On Wed, Sep 18, 2013 at 12:41:11AM +0530, Manish Badarkhe wrote: > Hi Dmitry, > > On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx> wrote: > > Hi Manish, > > > > On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: > >> Update the code to use devm_* API so that driver core will manage > >> resources. > >> > > > > And the benefit of this would be...? > > > > There are still resources that are managed in traditional way and I > > really dislike mixing the 2 styles. I can see applying patch that > > converts the driver to use devm_ for all its resources and gets rid of > > the remove() method altogether, but I am not sure how beneficial this > > kind of changes are for existing drivers. > > IMO devm_ makes us to manage resources properly without much care about freeing > it ( as devm_handles freeing automatically). Are the resources released improperly in the current version of the driver? IOW I do not see the point in applying this patch as it does not make the driver materially better. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |