Re: [PATCH] Input: gpio-keys - update to devm_* API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> Hi Manish,
>
> On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote:
>> Update the code to use devm_* API so that driver core will manage
>> resources.
>>
>
> And the benefit of this would be...?
>
> There are still resources that are managed in traditional way and I
> really dislike mixing the 2 styles. I can see applying patch that
> converts the driver to use devm_ for all its resources and gets rid of
> the remove() method altogether, but I am not sure how beneficial this
> kind of changes are for existing drivers.

IMO devm_ makes us to manage resources properly without much care about freeing
it ( as devm_handles freeing automatically). But, stiil  there are use
cases which makes
us to mix this devm_  with traditionally managed resources.
Not much sure about any other benefits.

Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux