On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:
> Hi Tomasz,
>
> On 5 September 2013 15:25, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote:
> > Hi Chander,
> >
> > On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
> >> Exynos5420 is octacore SoC from samsung.
> >> Hence populate all the cpu node enteries.
> >>
> >> Signed-off-by: Chander Kashyap <chander.kashyap@xxxxxxxxxx>
> >> ---
> >>
> >> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -57,6 +57,34 @@
> >>
> >> reg = <0x3>;
> >> clock-frequency = <1800000000>;
> >>
> >> };
> >>
> >> +
> >> + cpu4: cpu@4 {
> >
> > I believe this is a typo. The @unit-address suffix should match the
> > value of reg property.
>
> No this is not typo. It is the MPIDR value of the cpu. (24 bits of
> MPIDR register).
Right. This is what the reg property should be set to. However, the @unit-
address prefix of node name should match the value of reg property, so if
the value of reg property is 0x100, then the node should be named cpu@100.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
