Re: [PATCH] ARM: dts: Fix gpio pin of lcd_en node for exynos4210

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, September 03, 2013 5:48 PM, Tushar Behera wrote:
> On 3 September 2013 13:03, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> > On Tuesday, September 03, 2013 3:52 PM, Tushar Behera wrote:
> >> On 3 September 2013 07:44, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> >> > According to datasheet, 'lcd_en' node should use gpf0-2,
> >> > instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus,
> >> > it should be fixed.
> >> >
> >> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> >> > ---
> >> >  arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi b/arch/arm/boot/dts/exynos4210-
> pinctrl.dtsi
> >> > index a7c2128..da5dd8d 100644
> >> > --- a/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> >> > +++ b/arch/arm/boot/dts/exynos4210-pinctrl.dtsi
> >> > @@ -374,7 +374,7 @@
> >> >                 };
> >> >
> >> >                 lcd_en: lcd-en {
> >> > -                       samsung,pins = "gpe3-4";
> >> > +                       samsung,pins = "gpf0-2";
> >> >                         samsung,pin-function = <2>;
> >> >                         samsung,pin-pud = <0>;
> >> >                         samsung,pin-drv = <0>;
> >>
> >> With this change, the LCD display stops working on Origen board.
> >
> > The smdkv310 board worked properly.
> > gpe3-4 seems to be necessary for Origen board.
> > Can you describe why gpe3-4 is necessary for Origen board?
> >
> 
> Without setting this pin, LCD panel doesn't power up. It is quite
> possible that this is Origen specific. In that case, how do you
> suggest to implement this for Origen board?

OK, I see.
'gpe3-4' on Origen board is used as LCD panel reset pin.
Then, it should be handled as reset-pin control for LCD panel.

Also, one this is clear.
'gpe3-4' should NOT be used as pin-function <2>, because
it means MDM_DATA[4]. MDM_DATA[4] is not related to LCD control.
It is a definitely wrong usage.

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux