On Mon, Jul 29, 2013 at 05:31:16PM +0530, Padma Venkat wrote:
> On Sat, Jul 27, 2013 at 6:46 AM, Padma Venkat <padma.kvr@xxxxxxxxx> wrote:
> >>> + vdd: fixed-regulator@0 {
> >>> + compatible = "regulator-fixed";
> >>> + regulator-name = "vdd-supply";
> >> These names look wrong - they should reflect the names in the schematic
> >> as they're for human comprehensibility. This may just be a case of
> >> dropping the -supply.
> When I posted the same patch for smdk5250, you asked me to club all
> the same supply regulators. So I clubbed AVDD2 and CPVDD. So any other
> better name for representing both supplies?
No, I'd have told you to combine things taht come from the same supply
on the board - things like the speaker supplies for example aren't going
to be coming from separate places. The names should reflect whatever
the names on the schemaric are, like I say that's probably just removing
the -supply.
> >> documentation update the other day, it's in my tree now) but it's not
> >> essential and I suspect it needs some work on the clock driver side
> >> still.
> > OK. I will check this.
> As per schemata, input clock to MCLK1 is an oscillator clock with
> 16.9MHz and MCLK2 not showing any input clock. So here I need to add a
> fixed rate clock with 16.9MHz as MCLK1 in the smdk board file.
> Is it correct?
Yes, in the DTS (or to XCLKOUT on the AP?).
Attachment:
signature.asc
Description: Digital signature
