On Fri, Jul 26, 2013 at 07:06:51PM +0530, Padmavathi Venna wrote:
> This patch adds wm8994 codec node on i2c bus1 and the required
> regulator supplies and properties on smdk5420 board.
This isn't a device tree patch for WM8994, it's a patch for the
SMDK5420.
> + vdd: fixed-regulator@0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-supply";
These names look wrong - they should reflect the names in the schematic
as they're for human comprehensibility. This may just be a case of
dropping the -supply.
> + wm8994: wm8994@1a {
> + compatible = "wlf,wm8994";
> + reg = <0x1a>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + AVDD2-supply = <&vdd>;
> + CPVDD-supply = <&vdd>;
> + DBVDD-supply = <&dbvdd>;
> + SPKVDD1-supply = <&spkvdd>;
> + SPKVDD2-supply = <&spkvdd>;
> + };
It would be helpful to also add a clock binding (I posted a binding
documentation update the other day, it's in my tree now) but it's not
essential and I suspect it needs some work on the clock driver side
still.
Attachment:
signature.asc
Description: Digital signature
