Thanks Sachin, On Wed, Jul 24, 2013 at 2:12 PM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: > Hi Dongjin, > > On 23 July 2013 23:01, Dongjin Kim <tobetter@xxxxxxxxx> wrote: >> This patch adds device nodes for USBPHY to Exynos4x12. >> >> Signed-off-by: Dongjin Kim <tobetter@xxxxxxxxx> >> --- >> arch/arm/boot/dts/exynos4x12.dtsi | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi >> index 01da194..9c3335b 100644 >> --- a/arch/arm/boot/dts/exynos4x12.dtsi >> +++ b/arch/arm/boot/dts/exynos4x12.dtsi >> @@ -73,4 +73,22 @@ >> clock-names = "sclk_fimg2d", "fimg2d"; >> status = "disabled"; >> }; >> + >> + usbphy@125B00000 { > > Extra 0 above. > This is my bad, I will fix. >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "samsung,exynos4x12-usb2phy"; >> + reg = <0x125B0000 0x100>; >> + ranges; >> + >> + clocks = <&clock 2>, <&clock 305>; >> + clock-names = "xusbxti", "otg"; >> + status = "disabled"; >> + >> + usbphy-sys { >> + /* USB device and host PHY_CONTROL registers */ >> + reg = <0x10020704 0xc>, >> + <0x1001021c 0x4>; >> + }; >> + }; >> }; > > Please add this node after tmu node (satisfies alphabetical order as > well as increasing address value) No tmu node in exynos4x12.dtsi in mainline v3.11-rc2 yet, even in Kukjin's branch. > > > -- > With warm regards, > Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html