Hi Sachin,
On Tue, Jul 23, 2013 at 8:28 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Hi Leela,
>
> On 22 July 2013 11:44, Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> wrote:
>> This patch removes the global variables in the driver file and
>> group them into a structure.
>>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
>> ---
>> Note: This patch is rebased on kgene's for-next branch and tested on SMDK5420.
>>
>> Changes since V1:
>> - changed the patch subject.
>> - indentation correction in s3c2410_watchdog structure.
>>
>> drivers/watchdog/s3c2410_wdt.c | 204 +++++++++++++++++++++++-----------------
>> 1 file changed, 119 insertions(+), 85 deletions(-)
>>
>> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
>> index 6a22cf5..de679d0 100644
>> --- a/drivers/watchdog/s3c2410_wdt.c
>> +++ b/drivers/watchdog/s3c2410_wdt.c
>> @@ -84,13 +84,20 @@ MODULE_PARM_DESC(soft_noboot, "Watchdog action, set to 1 to ignore reboots, "
>> "0 to reboot (default 0)");
>> MODULE_PARM_DESC(debug, "Watchdog debug, set to >1 for debug (default 0)");
>>
>> -static struct device *wdt_dev; /* platform device attached to */
>> -static struct resource *wdt_mem;
>> -static struct resource *wdt_irq;
>> -static struct clk *wdt_clock;
>> -static void __iomem *wdt_base;
>> -static unsigned int wdt_count;
>> -static DEFINE_SPINLOCK(wdt_lock);
>> +struct s3c2410_watchdog {
>> + struct device *dev; /* platform device attached to */
>
> Since you would anyway be respinning this patch to address comments
> from Tomasz, please remove the above comment too.
>
Done
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
