Re: clk: Exynos5250: Add clocks for G3D

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Doug,

Thanks for the review.
But as per Tomasz Figa's comment, I will remove the exporting of aclk_400_g3d
to the driver.

Regards
Arun

On Wed, May 22, 2013 at 4:13 AM, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> Arun,
>
> On Tue, May 21, 2013 at 5:36 AM, Arun Kumar K <arun.kk@xxxxxxxxxxx> wrote:
>> @@ -262,6 +270,7 @@ struct samsung_div_clock exynos5250_div_clks[] __initdata = {
>>         DIV(none, "aclk166", "mout_aclk166", DIV_TOP0, 8, 3),
>>         DIV(none, "aclk333", "mout_aclk333", DIV_TOP0, 20, 3),
>>         DIV(none, "aclk200", "mout_aclk200", DIV_TOP0, 12, 3),
>> +       DIV(aclk_400_g3d, "aclk_400_g3d", "mout_aclk400", DIV_TOP0, 24, 3),
>
> Doh!  I looked at this more and it looks like I missed something.
> You've added this clock to the range assigned for "[Peripheral Clock
> Gates]".  This is not a gate clock but is a div clock.
>
> Perhaps it should be in a different range?  Could make IDs that start
> at 512 or something?
>
> -Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux