Tomasz, On Thu, May 16, 2013 at 3:37 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > Well, to make long story short, including headers from plat/ and mach/ > from files outside plat/ or mach/ is no longer valid with > CONFIG_MULTIPLATFORM, because more than one plat and/or mach can be > enabled at the same time. In addition to this, care must be taken for code > to not break platforms other than written for, when compiled into the > resulting kernel. Right. That makes sense. That's also why it would be a bit of a longshot for me to get this done right now. I'd imagine that there would be a number of changes to the samsung pm infrastructure that are needed to make this work and I don't have all of those in my tree right now. We've already picked back a lot to 3.8, but multiplatform seems too much. >> Perhaps for this patch it makes more sense for you to post your >> version and I can review it? We may end up just keeping our version >> of this patch for 3.8 and pick up yours when we do our next rebase. >> Does that sound OK? > > Fine. I will also send a patch adding save and restore for several EINT > registers that need it. OK, sounds good. I was trying to figure out why we didn't seem to have those in our 3.4 stuff and that it seems to work without saving/restoring. I assumed that maybe higher level code was masking/unmasking interrupts but didn't dig. > Since EINT handling is highly SoC-specific (i.e. done in pinctrl-exynos, > not pinctrl-samsung), such assumption wouldn't be a problem. Let me see > how I solved this problem in my version tomorrow at work. Fair enough. :) Looking forward to seeing your patch! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html