Hi Padmavathi, On Tuesday 07 of May 2013 09:09:01 Padmavathi Venna wrote: > This patch fixes a null pointer deference in i2s driver in DT > case > > Signed-off-by: Padmavathi Venna <padma.v@xxxxxxxxxxx> > --- > > This patch is dependent on below patch posted by Thomas Abraham. > https://patchwork.kernel.org/patch/2224801/ > > sound/soc/samsung/i2s.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c > index 7ce7c50..eaf6439 100644 > --- a/sound/soc/samsung/i2s.c > +++ b/sound/soc/samsung/i2s.c > @@ -1182,7 +1182,7 @@ static int samsung_i2s_probe(struct platform_device > *pdev) pri_dai->sec_dai = sec_dai; > } > > - if (i2s_pdata->cfg_gpio && i2s_pdata->cfg_gpio(pdev)) { > + if (i2s_pdata && i2s_pdata->cfg_gpio && i2s_pdata->cfg_gpio(pdev)) { This is a problem that needs to be fixed indeed. However the same problem exists in samsung_i2s_remove() as well (at least in latest linux-next). This makes me wonder what happens with i2s_pdata in DT case. Most of drivers allocate a pdata struct anyway and fill it with data parsed from device tree. This allows rest of the code to remain unmodified and consider DT and non-DT cases equal. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Kernel and System Framework -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |