On Sat, Apr 27, 2013 at 6:20 AM, Zhang Rui <rui.zhang@xxxxxxxxx> wrote: > Hi, all, > > what is the status now? > which one is preferred, this one or the one from Amit's patch set? Hi Rui, I have still not submitted LDO support in the TMU driver. I will re-base Lukasz patches on top of my patch series and submit shortly as his changes are also important. Thanks, Amit Daniel > > thanks, > rui > > > On Thu, 2013-04-25 at 18:29 +0200, Lukasz Majewski wrote: >> Hi Eduardo, >> >> > Amit, Lukasz, >> > >> > On 25-04-2013 09:29, Lukasz Majewski wrote: >> > > Hi Amit, >> > > >> > >> Hi Lukasz Majewski, >> > >> >> > >> Sorry for late review but I am currently working on restructuring >> > >> the whole exynos thermal driver and this support of LDO can be >> > >> added as feature as not all socs support this. This is also >> > >> suggested by Eduardo. All your other patches looks fine. >> > > >> > > But this is how it is already done. The VDD_TS is optional, so >> > > Exynos5440 and Exynos4210 will not be broken. >> > > >> > > This shall preserve the correct behavior of the thermal driver. >> > > >> > >> > If you guys plan to move to feature based approach, like suggested in >> > V1, then Id recommend adding a /* TODO: */ entry in your driver. >> >> Ok, nice idea. >> >> > >> > Amit, are you including this LDO support on your rework? >> >> >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html