On Tuesday 16 of April 2013 08:09:10 Rob Herring wrote:
> On 04/15/2013 04:14 PM, Tomasz Figa wrote:
> > This patch adds basic device tree definitions for Samsung S3C64xx SoCs.
> >
> > Since all the SoCs in the series are very similar, the files are created
> > hierarchically - one file for the whole series and then separate files
> > for particular SoCs including the common one.
> >
> > Signed-off-by: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> > ---
> >
> > arch/arm/boot/dts/s3c6400.dtsi | 33 ++
> > arch/arm/boot/dts/s3c6410.dtsi | 33 ++
> > arch/arm/boot/dts/s3c64xx-pinctrl.dtsi | 683
> > +++++++++++++++++++++++++++++++++ arch/arm/boot/dts/s3c64xx.dtsi
> > | 136 +++++++
> > 4 files changed, 885 insertions(+)
> > create mode 100644 arch/arm/boot/dts/s3c6400.dtsi
> > create mode 100644 arch/arm/boot/dts/s3c6410.dtsi
> > create mode 100644 arch/arm/boot/dts/s3c64xx-pinctrl.dtsi
> > create mode 100644 arch/arm/boot/dts/s3c64xx.dtsi
>
> [...]
>
> > +
> > + vic0: interrupt-controller@71200000 {
>
> These nodes should be off a "simple-bus" node.
Hmm, is there any reason behind it?
I thought simple bus was just a convenient helper to represent hierarchical
bus structures if one has a need to do so.
Best regards,
Tomasz
> Rob
>
> > + compatible = "arm,pl192-vic";
> > + interrupt-controller;
> > + reg = <0x71200000 0x1000>;
> > + #interrupt-cells = <1>;
> > + };
> > +
> > + vic1: interrupt-controller@71300000 {
> > + compatible = "arm,pl192-vic";
> > + interrupt-controller;
> > + reg = <0x71300000 0x1000>;
> > + #interrupt-cells = <1>;
> > + };
> > +
> > + pinctrl0: pinctrl@7f008000 {
> > + compatible = "samsung,s3c64xx-pinctrl";
> > + reg = <0x7f008000 0x1000>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <21>;
> > +
> > + pctrl_int_map: pinctrl-interrupt-map {
> > + interrupt-map = <0 &vic0 0>,
> > + <1 &vic0 1>,
> > + <2 &vic1 0>,
> > + <3 &vic1 1>;
> > + #address-cells = <0>;
> > + #size-cells = <0>;
> > + #interrupt-cells = <1>;
> > + };
> > +
> > + wakeup-interrupt-controller {
> > + compatible = "samsung,s3c64xx-wakeup-eint";
> > + interrupts = <0>, <1>, <2>, <3>;
> > + interrupt-parent = <&pctrl_int_map>;
> > + };
> > + };
> > +
> > + pwm: pwm@7f006000 {
> > + compatible = "samsung,s3c6400-pwm";
> > + reg = <0x7f006000 0x1000>;
> > + interrupt-parent = <&vic0>;
> > + interrupts = <23>, <24>, <25>, <27>, <28>;
> > + samsung,pwm-outputs = <0>, <1>;
> > + #pwm-cells = <3>;
> > + status = "disabled";
> > + };
> > +
> > + uart0: serial@7f005000 {
> > + compatible = "samsung,s3c6400-uart";
> > + reg = <0x7f005000 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <5>;
> > + status = "disabled";
> > + };
> > +
> > + uart1: serial@7f005400 {
> > + compatible = "samsung,s3c6400-uart";
> > + reg = <0x7f005400 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <6>;
> > + status = "disabled";
> > + };
> > +
> > + uart2: serial@7f005800 {
> > + compatible = "samsung,s3c6400-uart";
> > + reg = <0x7f005800 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <7>;
> > + status = "disabled";
> > + };
> > +
> > + uart3: serial@7f005c00 {
> > + compatible = "samsung,s3c6400-uart";
> > + reg = <0x7f005c00 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <8>;
> > + status = "disabled";
> > + };
> > +
> > + sdhci0: sdhci@7c200000 {
> > + compatible = "samsung,s3c6410-sdhci";
> > + reg = <0x7c200000 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <24>;
> > + status = "disabled";
> > + };
> > +
> > + sdhci1: sdhci@7c300000 {
> > + compatible = "samsung,s3c6410-sdhci";
> > + reg = <0x7c300000 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <25>;
> > + status = "disabled";
> > + };
> > +
> > + sdhci2: sdhci@7c400000 {
> > + compatible = "samsung,s3c6410-sdhci";
> > + reg = <0x7c400000 0x100>;
> > + interrupt-parent = <&vic1>;
> > + interrupts = <17>;
> > + status = "disabled";
> > + };
> > +};
> > +
> > +/include/ "s3c64xx-pinctrl.dtsi"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
> in the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Kernel and System Framework
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
