On Wednesday, April 03, 2013, Doug Anderson wrote: > Thomas, > > On Mon, Apr 1, 2013 at 11:09 PM, Thomas Abraham > <thomas.abraham@xxxxxxxxxx> wrote: > > With device core now able to setup the default pin configuration, > > the pin configuration code based on the deprecated Samsung specific > > gpio bindings is removed. > > > > Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > You missed Seungwon's other feedback. Please change the title from > "mmc: dwmmc: let device core setup the default pin configuration" to > "mmc: dw_mmc: let device core setup the default pin configuration". > He requested that the tag have the underscore in it for consistency. > > If you're resending, it also seems like it might be nice to rebase this atop: > > 0f6e73d mmc: dw_mmc: Add MSHC compatible for Exynos4412 > > ...just to avoid the simple merge conflict when applying? > > Otherwise everything here looks great... > > -Doug Thomas, It's a conflict to merge. Please do rebase the patch. Thanks, Seungwon Jeon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |