On Friday, January 25, 2013 10:26:41 AM Kukjin Kim wrote: > Sachin Kamat wrote: > > > > 'ret' is undefined when the function returns from the first > > 'if' condition. Without this patch we get the following warning: > > > > drivers/cpufreq/exynos-cpufreq.c: In function ‘exynos_target’: > > drivers/cpufreq/exynos-cpufreq.c:182:2: warning: > > ‘ret’ may be used uninitialized in this function [-Wuninitialized] > > > > Suggested-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx> > > I modified above to 'Reported-by' because checkpatch complains like following... > > WARNING: Non-standard signature: Suggested-by: > #10: > Suggested-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx> This tag has been used already, though, and I think it makes sense (more than Reported-by in this case). I think it may be regarded as standard regardless of what checkpatch has to say about that. :-) Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |