Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: >>>>> - { .compatible = "samsung,exynos-dwc3" }, >>>>> + { .compatible = "samsung,synopsis-dwc3" } >>>> >>>> You're both missing a point here. The synopsys IP driver is called >>>> dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver >>>> (dwc3-exynos.ko) is compatible with your platform, so >>>> samsung,exynos-dwc3 sounds correct to me. >>>> >>> Hmm...yeah, you're right and agreed. >>> >>> However, we need to use more clear name there like "samsung,exynos-dwusb3" >>> in compatible, because you know there are lots of other IPs in Synopsis >>> Design Ware brand. So we have to include usb in compatible for that. >> >> fair enough. >> > > Thanks for your suggestions. This definitely make things clear. > I shall then keep "samsung,exynos-dwusb3" as the compatible string or, > should i be including '5250' string as well, something like > "samsung,exynos5250-dwusb3" > as pointed out by Grant earlier ? :-O IMHO this needs to be "samsung,exynos5250-dwusb3", rather than "samsung,exynos-dwusb3". :) -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html