On Tue, Jan 8, 2013 at 9:35 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> Olof Johansson wrote:
>>
>> Hi,
>>
>> On Mon, Dec 31, 2012 at 3:33 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx>
>> wrote:
>> > Since exynos5440 can support only common clk stuff, so this
>> > patch skips legacy exynos5 clock initialization.
>> >
>> > Signed-off-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
>> > ---
>> > arch/arm/mach-exynos/common.c | 7 +++++++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-
>> exynos/common.c
>> > index d6d0dc6..1a89824 100644
>> > --- a/arch/arm/mach-exynos/common.c
>> > +++ b/arch/arm/mach-exynos/common.c
>> > @@ -424,11 +424,18 @@ static void __init exynos5_init_clocks(int xtal)
>> > {
>> > printk(KERN_DEBUG "%s: initializing clocks\n", __func__);
>> >
>> > + /* EXYNOS5440 can support only common clock framework */
>> > +
>> > + if (soc_is_exynos5440())
>> > + return;
>> > +
>> > +#ifdef CONFIG_SOC_EXYNOS5250
>>
>> Why are you adding an ifdef here, when the return above will take care
>> of returning early for 5440?
>>
> Without this, compilation error should be happened when we builds only for
> exynos5440 without selection exynos5250, because you know, current
> exynos5440 stuff cannot support legacy exynos5 clock. Of course, the ifdef
> will be going away when we support common clock on all of exynos stuff, but
> it's v3.9 not v3.8 so I think, we need this for now.
> Note, exynos5440 is working fine on current mainline + v3.8-samsung-fixes-2
> without any configuration clock stuff in kernel because hardware initial
> value is ok.
Why is there a need to have a config option for 5250 and 5440? They
are similar enough that there shouldn't be much overhead to just have
a EXYNOS5 option that includes both. It's how some of the other SoCs
handle this (OMAP and Tegra, for example).
That would reduce the amount of ifdefs in your code as well, for cases
like these. I think it's a good idea -- especially since these parts
are used in bigger systems where saving the last 2k of code/data isn't
as critical. Having easy-to-maintain code is worth more in most of
those cases.
So, I'll pull the branch but please consider removing the config
options in 3.9, and not adding new ones for future similar parts if at
all possible.
Thanks!
-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
