Heiko Stübner wrote: > > Second version of redoing the s3c24xx irqs in a generic way by using a > declarative approach. > > Changes include further generalizations resulting only in common > irq-type declarations being needed and thus again easier code. > > As in the first version, the 1st patch might be hard to read due to the > rewrite character, but I didn't see a way to do these changes in individual > steps. So it might be helpful to look at the result after applying this patch. > > Runtime-tested on a s3c2416 based board and compile tested for the others. > > As also written before, inclusion of the other S3C24XX SoCs to follow once > the general approach is acceptable. > > Heiko Stuebner (11): > ARM: S3C24XX: transform irq handling into a declarative form > ARM: S3C24XX: move irq-pm code into main irq file > ARM: S3C24XX: cleanup irq-pm integration > ARM: S3C24XX: move s3c2416 irq init to common irq code > ARM: S3C24XX: modify s3c2416 irq init to initialize all irqs > ARM: S3C24XX: assimilate s3c2416 subirqs into new structure > ARM: S3C24XX: assimilate second s3c2416 interrupt into new structure > ARM: S3C24XX: move s3c2443 irq code to irq.c > ARM: S3C24XX: modify s3c2443 irq init to initialize all irqs > ARM: S3C24XX: assimilate s3c2443 subirqs into new structure > ARM: S3C24XX: remove maskack irq ack funtions > > arch/arm/mach-s3c24xx/Makefile | 6 +- > arch/arm/mach-s3c24xx/common.h | 2 + > arch/arm/mach-s3c24xx/irq-pm.c | 95 --- > arch/arm/mach-s3c24xx/irq-s3c2416.c | 348 -------- > arch/arm/mach-s3c24xx/irq-s3c2443.c | 281 ------- > arch/arm/mach-s3c24xx/mach-smdk2416.c | 2 +- > arch/arm/mach-s3c24xx/mach-smdk2443.c | 2 +- > arch/arm/mach-s3c24xx/s3c2410.c | 4 +- > arch/arm/mach-s3c24xx/s3c2412.c | 4 +- > arch/arm/mach-s3c24xx/s3c2416.c | 4 +- > arch/arm/mach-s3c24xx/s3c2440.c | 4 +- > arch/arm/mach-s3c24xx/s3c2442.c | 4 +- > arch/arm/plat-s3c24xx/Kconfig | 1 + > arch/arm/plat-s3c24xx/irq.c | 1092 +++++++++++++++----------- > arch/arm/plat-samsung/include/plat/pm.h | 6 - > arch/arm/plat-samsung/include/plat/s3c2416.h | 1 + > arch/arm/plat-samsung/include/plat/s3c2443.h | 2 + > 17 files changed, 649 insertions(+), 1209 deletions(-) > delete mode 100644 arch/arm/mach-s3c24xx/irq-pm.c > delete mode 100644 arch/arm/mach-s3c24xx/irq-s3c2416.c > delete mode 100644 arch/arm/mach-s3c24xx/irq-s3c2443.c > Hi Heiko, Happy New Year! Basically, looks OK but will look at in this weekend :-) BTW, I have no idea why you want to keep the irq.c in plat-s3c24xx. As I said, I'm cleaning up the plat-s3c24xx directory and it will be going away. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |