Olof Johansson wrote: > > Hi, > Hi, [...] > It seems better to create a helper function here instead and calling > that, instead of switching to a conditional open-coded block to this > function. > Yes, sounds good. I will. > > @@ -178,6 +183,8 @@ static void __init exynos_smp_init_cpus(void) > > > > if (soc_is_exynos5250()) > > ncores = 2; > > + else if (soc_is_exynos5440()) > > + ncores = 4; > > In the future it would make sense to get the core count from the > device tree instead. > Agreed. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html