Hi Kgene, On Tuesday 20 of November 2012 18:18:44 Kukjin Kim wrote: > Tomasz Figa wrote: > > This patch modifies pin control groups of SD pins on Exynos4210 and > > Exynos4x12 to use drive strength 3, which corresponds to > > S5P_GPIO_DRVSTR_LV4 in legacy non-DT code. > > Well, the value of drive strength depends on board not SoC. So if > required, it should be moved to board DT stuff. Yes, I fully agree. I've been thinking whether to change the defaults or just override them for Origen, but I came to a conclusion that 3 (LV4) was the default in non-DT code, so it probably should be also the default in DT variant. > BTW, we can use the value as a default...I need to think about that > again for exynos4210 and 4x12. I wonder which default value is more appropriate, 0 or 3? Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |