On 08/21/2012 07:08 AM, Arnd Bergmann wrote: > On Tuesday 21 August 2012, Chris Ball wrote: >> How about this? >> >> broken-cd: No CD available, use polling. >> >> cd-gpios: The CD pin on the host is working and brought out to a GPIO. >> >> external-cd-gpios: The CD pin on the host is broken, but there's an >> independent external GPIO available. >> >> >> (Each host should only have one of these properties.) > > The fsl-imx-esdhc.txt binding already has all three cases, but > describes them differently: > > fsl,cd-internal: when present, the CD pin on the host is working > cd-gpios: when present, contains the gpio line that CD is connected to > If both are absent, it has to use polling. This makes the most sense to me. However, I prefer broken-cd over cd-internal. The binding should add properties for exceptions, not SDHCI spec compliant implementations. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html