On Wed, Aug 15, 2012 at 10:10 PM, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote: > + pinctrl@11400000 { > + uart0_data: uart0-data { > + samsung,pins = "gpa0-0", "gpa0-1"; > + samsung,pin-function = <0x2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; Apart from the pin-pud and pin-drv stuff this patch looks fine. These two things I want to discuss in the other mail thread (controller core) first. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html