Re: [PATCH 2/2] leds: Convert S3C24XX LED driver to gpiolib API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/03/2012 04:30 AM, Bryan Wu wrote:
...
>>> Overall, these 2 patches are good. I'm just curious why not we just
>>> use generic led-gpio driver to replace this one.
>>
>> Thank you for the suggestion, I wasn't really aware of generic leds-gpio
>> driver... This could be nice optimization. However my intention was
>> to just clean up the GPIO bits, with minimal changes to other subsystems.
>> I could check and see how it could be done perhaps as a next step ?
> 
> Sure, no problem. I will merge these 2 patches soon.

Thank you.

>> There is a few (old) boards that use this driver and converting them would
>> delay the GPIO patches even further...
>>
>> Also generic led-gpio has some limitations, e.g. I couldn't see it supports
>> tri-stating a GPIO when a LED is off. Probably this feature could be added.
>>
> 
> Good point, I will help to take a look.

I should get back to this when I find some more time.

That might not be difficult, probably gpio_request_one() with GPIOF_OPEN_DRAIN/
GPIOF_OPEN_SOURCE flag instead of gpio_request() would do.

--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux