On Tue, Jul 3, 2012 at 4:18 AM, Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> wrote: > Hi, > > On 07/02/2012 05:35 AM, Bryan Wu wrote: >> On Sat, Jun 30, 2012 at 8:30 PM, Sylwester Nawrocki >> <sylvester.nawrocki@xxxxxxxxx> wrote: >>> The s3c2410_gpio* calls are obsolete and have been scheduled for >>> removal since several kernel releases. Remove them and use common >>> gpiolib API instead. >>> This patch also adds gpio_request/gpio_free call for API corectness. >>> >>> It is a prerequisite for removal of the S3C24XX SoC specific >>> arch/arm/plat-samsung/include/gpio-fns.h header. >>> >>> Tested on Micro2440-SDK. >>> >> >> Overall, these 2 patches are good. I'm just curious why not we just >> use generic led-gpio driver to replace this one. > > Thank you for the suggestion, I wasn't really aware of generic leds-gpio > driver... This could be nice optimization. However my intention was > to just clean up the GPIO bits, with minimal changes to other subsystems. > I could check and see how it could be done perhaps as a next step ? Sure, no problem. I will merge these 2 patches soon. > There is a few (old) boards that use this driver and converting them would > delay the GPIO patches even further... > > Also generic led-gpio has some limitations, e.g. I couldn't see it supports > tri-stating a GPIO when a LED is off. Probably this feature could be added. > Good point, I will help to take a look. Thanks, -- Bryan Wu <bryan.wu@xxxxxxxxxxxxx> Kernel Developer +86.186-168-78255 Mobile Canonical Ltd. www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |