Hi, On Wed, May 23, 2012 at 7:20 AM, <jonghwa3.lee@xxxxxxxxxxx> wrote: > Hi, again. > On 2012년 05월 22일 14:57, yadi.brar01@xxxxxxxxx wrote: > > >> +static __devinit int max77686_pmic_probe(struct platform_device *pdev) >> +{ > >> + >> + for (i = 0; i < pdata->num_regulators; i++) { >> + config.dev = max77686->dev; >> + config.init_data = pdata->regulators[i].init_data; >> + config.driver_data = max77686; >> + config.regmap = iodev->regmap; >> + >> + rdev[i] = regulator_register(®ulators[i], &config); > > > I'm sorry that i missed one. You have to register all regulators > unconditionally. Mark brown commented about this to my former patch. > > 'No, you should unconditionally register all regulators the device > physically has. This is useful for debug and simplifies the code.' > - from Mark Brown > Yes, we are registering all regulators here. As pdata->num_regulators will be equal to ARRAY_SIZE(regulators) Thanks, Yadwinder. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html