On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham <thomas.abraham@xxxxxxxxxx> wrote:
> Add support for device based discovery.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> Acked-by: Jaswinder Singh <jaswinder.singh@xxxxxxxxxx>
Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
... but one nitpick below...
> +#ifdef CONFIG_OF
> +static const struct of_device_id s3c64xx_spi_dt_match[] = {
> + { .compatible = "samsung,exynos4210-spi",
> + .data = (void *)EXYNOS4_SPI_PORT_CONFIG,
This looks completely backwards. EXYNOS4_SPI_PORT_CONFIG casts a
pointer to a kernel_ulong_t, and this casts it right back to a
pointer. The cast should be removed entirely from the macro, and the
platform_device_id table should have the cast from pointer to ulong.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
