Re: [PATCH 1/6] ARM: S3C64XX: Add usb otg phy control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/08/12 05:20, Lukasz Majewski wrote:
Hi Joonyoung,

On Thu, 8 Mar 2012 12:27:30 +0100
Joonyoung Shim<jy0922.shim@xxxxxxxxxxx>  wrote:

On 03/08/2012 06:52 PM, Kukjin Kim wrote:
On 03/07/12 04:28, Kukjin Kim wrote:
On 02/10/12 10:26, Mark Brown wrote:
On Fri, Feb 10, 2012 at 11:35:41AM +0100, Lukasz Majewski wrote:
From: Joonyoung Shim<jy0922.shim@xxxxxxxxxxx>

This patch supports to control usb otg phy of S3C64XX.
Currently, the driver for usb otg controls usb otg phy but it
can be removed by this patch.

Acked-by: Mark Brown<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Applied, thanks.


Oops, following error happened with s5pv210_defconfig after
applying this.

arch/arm/plat-samsung/built-in.o: In function
`s3c_hsotg_set_platdata': arch/arm/plat-samsung/devs.c:1449:
undefined reference to `s5p_usb_phy_init'
arch/arm/plat-samsung/devs.c:1449: undefined reference to
`s5p_usb_phy_init'
arch/arm/plat-samsung/devs.c:1451: undefined reference to
`s5p_usb_phy_exit'
arch/arm/plat-samsung/devs.c:1451: undefined reference to
`s5p_usb_phy_exit'
make: *** [.tmp_vmlinux1] Error 1


Also the s5pv210 needs setup-usb-phy.c file. I think the attached
patch will solve this errors. This patch was tested only compile.

Thanks.

Thank you for the patch.

I've extended your's patch by adding GONI dependent platform code.

It has been tested and works with s3c-hsotg driver.

Test HW:
GONI S5PC110

Tested-by: Lukasz Majewski<l.majewski@xxxxxxxxxxx>

Looks good to me.
Applied, Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux