On Sun, Feb 12, 2012 at 01:12:31PM +0000, Mark Brown wrote: > On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: > > From: Kisoo Yu <ksoo.yu@xxxxxxxxxxx> > > > need to set flag after finishing its work > > > - i2c->suspended = 0; > > clk_enable(i2c->clk); > > s3c24xx_i2c_init(i2c); > > clk_disable(i2c->clk); > > + i2c->suspended = 0; > > Why is this needed - given that there's no locking involved anywhere > here does this mean that we've got a race somewhere? It is in the wrong order, the lack of locking is a bit of a problem but then again so is the whole suspend/resume framework at the moment. I'm inclined to apply this to the fixes branch. -- Ben -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |