On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: > From: Kisoo Yu <ksoo.yu@xxxxxxxxxxx> > > need to set flag after finishing its work > > Signed-off-by: Kisoo Yu <ksoo.yu@xxxxxxxxxxx> > Signed-off-by: Huisung Kang <hs1218.kang@xxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-s3c2410.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 4c17180..7d6d2b7 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1082,10 +1082,10 @@ static int s3c24xx_i2c_resume(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev); > > - i2c->suspended = 0; > clk_enable(i2c->clk); > s3c24xx_i2c_init(i2c); > clk_disable(i2c->clk); > + i2c->suspended = 0; Yes, technically we should not mark ourselves as un-suspended until the peripheral has been properly restarted. I will have a look at Mark's comments before this is applied. -- Ben -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html