Dear Mr. Han, On 11 January 2012 14:46, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: > Hi, Thomas. > >> -----Original Message----- >> From: Thomas Abraham [mailto:thomas.abraham@xxxxxxxxxx] >> Sent: Tuesday, January 10, 2012 5:02 AM >> To: linux-fbdev@xxxxxxxxxxxxxxx; devicetree-discuss@xxxxxxxxxxxxxxxx >> Cc: FlorianSchandinat@xxxxxx; grant.likely@xxxxxxxxxxxx; rob.herring@xxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; kgene.kim@xxxxxxxxxxx; >> jg1.han@xxxxxxxxxxx; patches@xxxxxxxxxx >> Subject: [PATCH] video: s3c-fb: Add device tree support >> >> Add device tree based discovery support for Samsung's display controller. >> >> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> >> Cc: Rob Herring <rob.herring@xxxxxxxxxxx> >> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> >> --- >> .../devicetree/bindings/fb/samsung-fb.txt | 103 ++++++++++ >> drivers/video/s3c-fb.c | 209 +++++++++++++++++++- >> 2 files changed, 304 insertions(+), 8 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/fb/samsung-fb.txt >> >> [...] >> >> +- samsung,fimd-bpp: Specifies the bits per pixel. Two values should be >> + specified in the following order. >> + - max-bpp: maximum required bpp for the overlay. >> + - default-bpp: bpp supported by the overlay. >> [...] >> + fimd-overlay0 { >> + samsung,fimd-htiming = <64 16 48 1024>; >> + samsung,fimd-vtiming = <64 16 3 600>; >> + samsung,fimd-bpp = <24 32>; >> + }; >> + >> + fimd-overlay1 { >> + samsung,fimd-htiming = <64 16 48 200>; >> + samsung,fimd-vtiming = <64 16 3 100>; >> + samsung,fimd-bpp = <16 32>; >> + }; >> + }; > In the above 'samsung-fb.txt', the order is defined as max-bpp and default-bpp. > However, <24 32> and <16 32> seems to be wrong. > It should be <32 24> and <32 16>, respectively. > Max bpp would be 32bpp in s3c-fb. You are right. I will change the order in the documentation as default-bpp and then max-bpp. Thanks for correction. Regards, Thomas. > > Best regards, > Jingoo Han > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |