On Wed, Jan 04, 2012 at 03:15:44PM +0100, Heiko Stübner wrote: > regs-rtc.h uses a mixture of tabs and spaces and also (x<<y) > to format bits. So, before adding new stuff clean up the formatting > and also add spaces to the bit definitions (i.e. (x << y) ) Ok, so this is just a formatting change - and it should stay that way. However, there's an opportunity missed here. Are these register definitions used anywhere else other than in the drivers/rtc driver? If not, they should be placed along side that driver or even inside the driver itself. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html