Hi Kgene, Am Mittwoch, 4. Januar 2012, 12:51:41 schrieb Heiko Stübner: > Hi Sylwester, > > Am Mittwoch, 4. Januar 2012, 11:43:45 schrieb Sylwester Nawrocki: > > Hello, > > > > On 12/21/2011 10:16 AM, Heiko Stübner wrote: > > > Use the data field of of_device_id to hold the type for > > > s3c_cpu_type. > > > > > > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > > > Reviewed-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx> > > > --- > > > > This patch makes compilation with CONFIG_OF enabled fail with errors > > and warnings: > > > > drivers/rtc/rtc-s3c.c: In function ‘s3c_rtc_get_driver_data’: > > drivers/rtc/rtc-s3c.c:454: warning: return makes integer from pointer > > without a cast > > drivers/rtc/rtc-s3c.c: At top level: > > drivers/rtc/rtc-s3c.c:674: error: request for member ‘data’ in something > > not a structure or union > > drivers/rtc/rtc-s3c.c:677: error: request for member ‘data’ in something > > not a structure or union > > drivers/rtc/rtc-s3c.c:680: error: request for member ‘data’ in something > > not a structure or union > > drivers/rtc/rtc-s3c.c:683: error: request for member ‘data’ in something > > not a structure or union > > make[2]: *** [drivers/rtc/rtc-s3c.o] Error 1 > > thanks for spotting this. > > @kgene: Should this go on top of the rtc series, or should I prepare a v4 > with these fixes included? never mind, I did both. In reply to this mail you will find: - a single patch on top of the 4 original patches, fixing the problems sylwester reported - a v4 of the original series including the fixes to the problems, based on the code that you have in your rtc-branch Please pick the apropriate variant to fix the problem :-) Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |