Kyungmin Park wrote: > > On 12/24/11, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote: > > HeungJun, Kim wrote: > >> > >> This patch adds Samsung Mobile TRATS board support. > >> > >> Signed-off-by: HeungJun, Kim <riverful.kim@xxxxxxxxxxx> > >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >> --- > >> arch/arm/mach-exynos/Kconfig | 11 ++ > >> arch/arm/mach-exynos/Makefile | 1 + > >> arch/arm/mach-exynos/board-trats.c | 340 > >> ++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 352 insertions(+), 0 deletions(-) > >> create mode 100644 arch/arm/mach-exynos/board-trats.c > >> > > > > If this is for v3.3, unfortunately, it's a little late to add board file > and > > since many things have changed I don't want to cause the conflicts with > > others now. > > > > BTW, why is the name board-xxx not mach-xxx like others? > > It's mentioned several times, > How do you talk with other when talk about the smdk? > "I'm using the smdk machine and it's based on smdk machine?" > As board is more proper word and it's easy to know when find the board > at source code. > So hope to use the board if it's not big deal. > Yes, we say 'SMDK board blah blah' so it can be no big deal, but I don't want to make a confusion between CONFIG_MACH_XXX and mach-xxx.c yet even though there is a similar situation of arch/arm/mach-xxx/ directory and CONFIG_ARCH_XXX. In addition, the machine_is_xxx() is used to distinguish board in the kernel. Anyway, I think, if to use board-xxx.c is required, we can change it all at once and let me think again. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html